Drop appId from /open-debugger calls, disable matching for modern targets#47120
Closed
huntie wants to merge 1 commit into
Closed
Drop appId from /open-debugger calls, disable matching for modern targets#47120huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64597581 |
…gets (facebook#47120) Summary: Fixes no-op behaviour of the "Open DevTools" Dev Menu item (bug on `main` introduced with D63329456). This was caused by a change to the `description` field contents in our CDP `/json/list` response, when under Fusebox. In the `/open-debugger` call from the Dev Menu, we were still using the older `appId` param. This did not affect `j` to debug, which uses the `target` param. {F1937186832} Changes: In short: Matching against the `description` string is now fully eliminated for modern debugger targets. - Update native Dev Menu implementation to omit `appId` parameter (`device` param alone is sufficient and fully precise on these platforms). - Update `/open-debugger` implementation to ignore the `appId` parameter for modern targets, and document this in the `dev-middleware` README. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D64597581
huntie
force-pushed
the
export-D64597581
branch
from
3108811 to
27b1bce
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64597581 |
Contributor
|
This pull request has been merged in 6f42123. |
Collaborator
|
This pull request was successfully merged by @huntie in 6f42123 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes no-op behaviour of the "Open DevTools" Dev Menu item (bug on
mainintroduced with D63329456).This was caused by a change to the
descriptionfield contents in our CDP/json/listresponse, when under Fusebox. In the/open-debuggercall from the Dev Menu, we were still using the olderappIdparam.This did not affect
jto debug, which uses thetargetparam.{F1937186832}
Changes:
In short: Matching against the
descriptionstring is now fully eliminated for modern debugger targets.appIdparameter (deviceparam alone is sufficient and fully precise on these platforms)./open-debuggerimplementation to ignore theappIdparameter for modern targets, and document this in thedev-middlewareREADME.Changelog: [Internal]
Differential Revision: D64597581