Replace most of the remaining React.AbstractComponent in react-native#47143
Closed
SamChou19815 wants to merge 1 commit into
Closed
Replace most of the remaining React.AbstractComponent in react-native#47143SamChou19815 wants to merge 1 commit into
React.AbstractComponent in react-native#47143SamChou19815 wants to merge 1 commit into
Conversation
Summary: In order to adopt react 19's ref-as-prop model, we need to eliminate all the places where they are treated differently. `React.AbstractComponent` is the worst example of this, and we need to eliminate it. This diff replaces most of the remaining `React.AbstractComponent` in react-native. Reviewed By: alexmckenley Differential Revision: D64701145
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64701145 |
Contributor
|
This pull request has been merged in 723a37c. |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 723a37c When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In order to adopt react 19's ref-as-prop model, we need to eliminate all the places where they are treated differently.
React.AbstractComponentis the worst example of this, and we need to eliminate it.This diff replaces most of the remaining
React.AbstractComponentin react-native.Reviewed By: alexmckenley
Differential Revision: D64701145