cleanup: ExceptionsManager: Delete updateExceptionMessage#47167
Closed
RSNara wants to merge 4 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64606928 |
RSNara
force-pushed
the
export-D64606928
branch
from
88e3bdb to
b0b3bb2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64606928 |
RSNara
force-pushed
the
export-D64606928
branch
from
b0b3bb2 to
9b652ef
Compare
RSNara
force-pushed
the
export-D64606928
branch
from
9b652ef to
4d8588f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64606928 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64606928 |
RSNara
force-pushed
the
export-D64606928
branch
from
4d8588f to
2c59f8a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64606928 |
Summary: Now, handleError can be called with a JSError that wraps a non-error object! Changelog: [Internal] Reviewed By: javache Differential Revision: D64706198
…peline (facebook#47165) Summary: The c++ pipeline needs a javascript interface. We could just re-use exceptions manager (for now). Changelog: [Internal] Reviewed By: javache Differential Revision: D64779068
…facebook#47166) Summary: This method wasn't used from javascript. Changelog: [Internal] Reviewed By: javache Differential Revision: D64607415
Summary: I couldn't find any usages of this method in javascript. Removing, so that the native code is easier to read. Changelog: [Internal] Reviewed By: javache Differential Revision: D64606928
RSNara
force-pushed
the
export-D64606928
branch
from
2c59f8a to
86985dc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64606928 |
Contributor
|
This pull request has been merged in 4f47439. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I couldn't find any usages of this method in javascript.
Removing, so that the native code is easier to read.
Changelog: [Internal]
Differential Revision: D64606928