Skip to content

bugfix(image): add ts definition of resizeMethod attribute.#47227

Closed
nianxiongdi wants to merge 3 commits into
facebook:mainfrom
nianxiongdi:bugfix-image-ts
Closed

bugfix(image): add ts definition of resizeMethod attribute.#47227
nianxiongdi wants to merge 3 commits into
facebook:mainfrom
nianxiongdi:bugfix-image-ts

Conversation

@nianxiongdi
Copy link
Copy Markdown
Contributor

@nianxiongdi nianxiongdi commented Oct 27, 2024

Summary:

in the image component, add the ts definition with the resizeMethod attribute value as none.

Changelog:

[Android][Fixed] - the definition of ts of resizeMethod attribute is none.

Test Plan:

image

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @nianxiongdi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 27, 2024
@nianxiongdi nianxiongdi marked this pull request as draft October 28, 2024 01:33
@nianxiongdi nianxiongdi marked this pull request as ready for review October 28, 2024 01:35
@dnhan1707
Copy link
Copy Markdown

Hi @nianxiongdi , may I ask you how did you passed the Run Danger on PR / danger (pull_request_target) test please.
I keep having issue looks like this
Screenshot 2024-10-27 222220

@nianxiongdi
Copy link
Copy Markdown
Contributor Author

@dnhan1707 problem description is not standardized.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Comment thread packages/react-native/Libraries/Image/Image.d.ts Outdated
Comment thread packages/react-native/Libraries/Image/Image.d.ts Outdated
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@nianxiongdi
Copy link
Copy Markdown
Contributor Author

@Abbondanzo hello, is it possible to merge now?

@blakef
Copy link
Copy Markdown
Contributor

blakef commented Oct 30, 2024

@nianxiongdi apply prettier so it passes CI and I'll merge.

@blakef blakef self-assigned this Oct 30, 2024
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 30, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@Abbondanzo merged this pull request in 758892a.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @nianxiongdi in 758892a

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants