[iOS] Fixes regression of RCTWindowFrameDidChangeNotification not fired#47236
Closed
zhongwuzw wants to merge 2 commits into
Closed
[iOS] Fixes regression of RCTWindowFrameDidChangeNotification not fired#47236zhongwuzw wants to merge 2 commits into
zhongwuzw wants to merge 2 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
cipolleschi
approved these changes
Oct 28, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
@zhongwuzw great catch! thank you
…/fix_delegate_notification
Contributor
|
Lets wait on #47237 to land and rerun CI. |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @zhongwuzw in e271b23 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Oct 28, 2024
…7236) Summary: Fixes #47234. regression from 391680f#diff-b7fda5d350ac535115fa683faa7317b43aa11f3448f95266ef9ff051c3753a6fL63 bypass-github-export-checks ## Changelog: [IOS] [FIXED] - Fixes regression of RCTWindowFrameDidChangeNotification not fired Pull Request resolved: #47236 Test Plan: Demo in #47234. Reviewed By: blakef Differential Revision: D65058105 Pulled By: cipolleschi fbshipit-source-id: 0e286182ed93f289cb853710e2e00801ef2d4f73
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #47234. regression from 391680f#diff-b7fda5d350ac535115fa683faa7317b43aa11f3448f95266ef9ff051c3753a6fL63
Changelog:
[IOS] [FIXED] - Fixes regression of RCTWindowFrameDidChangeNotification not fired
Test Plan:
Demo in #47234.