RedBoxDialogSurfaceDelegate crash fix#47249
Closed
alanleedev wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65066186 |
alanleedev
force-pushed
the
export-D65066186
branch
from
48df3c6 to
7b15653
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65066186 |
Summary: - It is likely that Dialog is being dismissed from an invalid state causing an exception - apply similar changes from D63712422 which is to add try/catch around and ignore the exception as we are dismissing the dialog anyway Changelog: [Internal] Reviewed By: javache Differential Revision: D65066186
alanleedev
force-pushed
the
export-D65066186
branch
from
7b15653 to
78e66ac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65066186 |
Contributor
|
This pull request has been merged in 97622a5. |
Collaborator
|
This pull request was successfully merged by @alanleedev in 97622a5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Differential Revision: D65066186