Fix RTL ScrollView position when content smaller than container#47280
Closed
NickGerleman wants to merge 1 commit into
Closed
Fix RTL ScrollView position when content smaller than container#47280NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
Summary: Noticed in the screenshots of facebook#47230 that Android's logic of setting scroll content origin to zero, than right aligning scroll offset, won't correctly handle case where content is smaller than scrolling container. We can fix that by only resetting the origin when content overflows container, since we otherwise are not scrollable, and scroll adjustment will not translate. Changelog: [Android][Fixed] - Fix RTL ScrollView position when content smaller than container Differential Revision: D65136654
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65136654 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 29, 2024
…book#47280) Summary: Noticed in the screenshots of facebook#47230 that Android's logic of setting scroll content origin to zero, then right aligning scroll offset, won't correctly handle case where content is smaller than scrolling container. We can fix that by only resetting the origin when content overflows container, since we otherwise are not scrollable, and scroll adjustment will not translate. Changelog: [Android][Fixed] - Fix RTL ScrollView position when content smaller than container Differential Revision: D65136654
Contributor
|
This pull request has been merged in 0df59d4. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 0df59d4 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed in the screenshots of #47230 that Android's logic of setting scroll content origin to zero, then right aligning scroll offset, won't correctly handle case where content is smaller than scrolling container. We can fix that by only resetting the origin when content overflows container, since we otherwise are not scrollable, and scroll adjustment will not translate.
Changelog:
[Android][Fixed] - Fix RTL ScrollView position when content smaller than container
Differential Revision: D65136654