Minor typo in ReactHostImpl comment#47290
Closed
rozele wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65149529 |
…in bridgeless (facebook#47284) Summary: If the surface hasn't been set up yet, attempting to fetch the ReactRootView will throw a null reference exception. Since the result is already nullable, it's perhaps better to just return null when the surface has not yet been initialized. ## Changelog [Android][Fixed] Avoid null reference exception in bridgeless ReactDelegate Differential Revision: D65141137
Summary: Fixes a comment typo. ## Changelog [General][Fixed] Fixes typo in ReactHostImpl Reviewed By: cortinico Differential Revision: D65149529
rozele
force-pushed
the
export-D65149529
branch
from
4ab3aa8 to
b5e400a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65149529 |
Contributor
|
This pull request has been merged in e3f0326. |
Collaborator
|
This pull request was successfully merged by @rozele in e3f0326 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes a comment typo.
Changelog
[General][Fixed] Fixes typo in ReactHostImpl
Differential Revision: D65149529