Add mixBlendMode to iterator style parser#47292
Closed
jorge-cab wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65166886 |
jorge-cab
force-pushed
the
export-D65166886
branch
from
8671eef to
3eddd5b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65166886 |
jorge-cab
force-pushed
the
export-D65166886
branch
from
3eddd5b to
938e857
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65166886 |
jorge-cab
force-pushed
the
export-D65166886
branch
from
938e857 to
d5349c3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65166886 |
Summary: We missed fabric check for the mix-blend-mode conditional on `drawChildren` adding it now Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D65167244
Summary: If we don't add the prop to the iterator style parser then since fabric is not parsing the prop we are not properly creating the stacking context for when a prop has a mix-blend-mode set Changelog: [Internal] Reviewed By: javache Differential Revision: D65166886
jorge-cab
force-pushed
the
export-D65166886
branch
from
d5349c3 to
622ec09
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65166886 |
Contributor
|
This pull request has been merged in 2a2f58a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: If we don't add the prop to the iterator style parser then since fabric is not parsing the prop we are not properly creating the stacking context for when a prop has a mix-blend-mode set
Reviewed By: javache
Differential Revision: D65166886