Fix issue where text would truncate sometimes#47294
Closed
joevilches wants to merge 1 commit into
Closed
Conversation
Summary: TextView will set `setUseLineSpacingFromFallbacks` to `true` for their `StaticLayout`s while we ignore it in this case (`false` default). The docs even recommend setting it to `true`: https://developer.android.com/reference/android/text/StaticLayout.Builder#setUseLineSpacingFromFallbacks(boolean) We set this in the `StaticLayout` builder below, but not up here so lets do that. Changelog: [Internal] Differential Revision: D65171352
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65171352 |
Contributor
|
This pull request has been merged in 9f73ede. |
Collaborator
|
This pull request was successfully merged by @joevilches in 9f73ede When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
TextView will set
setUseLineSpacingFromFallbackstotruefor theirStaticLayouts while we ignore it in this case (falsedefault). The docs even recommend setting it totrue: https://developer.android.com/reference/android/text/StaticLayout.Builder#setUseLineSpacingFromFallbacks(boolean)We set this in the
StaticLayoutbuilder below, but not up here so lets do that.Changelog: [Internal]
Differential Revision: D65171352