Modernize in preparation for move to Layer Zero#47342
Closed
NSProgrammer wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65245787 |
NSProgrammer
force-pushed
the
export-D65245787
branch
from
3dd7968 to
092cc7e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65245787 |
NSProgrammer
force-pushed
the
export-D65245787
branch
from
092cc7e to
c417ccd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65245787 |
Summary: Pull Request resolved: facebook#47342 There are things we can do to modernize `FBHashKit` to make it ready for prime time, aka Layer Zero. * Consolidate down to a singular `meta_hash(...)` generic macro (supports all primitives for hashing) * Eliminate the unnecessary C++ * Deprecate legacy FB APIs * Make logic (and interfaces) explicit for 32 vs 64 bit inputs and 32 vs 64 bit outputs * Introduce robust unit tests * Have unit tests actually testable for 32-bit hashes ## Changelog [Internal][Change] Prep to move `FBXXHashUtils` Reviewed By: cipolleschi Differential Revision: D65245787
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65245787 |
NSProgrammer
force-pushed
the
export-D65245787
branch
from
c417ccd to
90f9249
Compare
Contributor
|
This pull request has been merged in f8fc90e. |
Collaborator
|
This pull request was successfully merged by Nolan O'Brien in f8fc90e When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There are things we can do to modernize
FBHashKitto make it ready for prime time, aka Layer Zero.meta_hash(...)generic macro (supports all primitives for hashing)Reviewed By: cipolleschi
Differential Revision: D65245787