Stable API - Make classes in com.facebook.react.views.safeareaview internal#47375
Closed
cortinico wants to merge 1 commit into
Closed
Stable API - Make classes in com.facebook.react.views.safeareaview internal#47375cortinico wants to merge 1 commit into
com.facebook.react.views.safeareaview internal#47375cortinico wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65422197 |
cortinico
force-pushed
the
export-D65422197
branch
from
dfdd0d0 to
73e769f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65422197 |
…internal (facebook#47375) Summary: This makes the following class internal: - ReactSafeAreaView - ReactSafeAreaViewManager Those classes should have not been exposed in the first place. Marked as breaking but no meaningful usages are available in OSS: https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+com.facebook.react.views.safeareaview.ReactSafeAreaView Changelog: [Android] [Breaking] - Stable API - Make classes in `com.facebook.react.views.safeareaview` internal Reviewed By: javache Differential Revision: D65422197
cortinico
force-pushed
the
export-D65422197
branch
from
73e769f to
af577ba
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65422197 |
Contributor
|
This pull request has been merged in 39dfbad. |
Collaborator
|
This pull request was successfully merged by @cortinico in 39dfbad When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This makes the following class internal:
Those classes should have not been exposed in the first place. Marked as breaking but no
meaningful usages are available in OSS:
https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+com.facebook.react.views.safeareaview.ReactSafeAreaView
Changelog:
[Android] [Breaking] - Stable API - Make classes in
com.facebook.react.views.safeareaviewinternalDifferential Revision: D65422197