Undo a breaking change on ReactViewGroup constructor#47423
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65483379 |
Summary: cipolleschi found out that we broke the `ReactViewGroup` constructor when making this class Nullsafe. Specifically now users would need to pass a `Context` and not a `Context?` as libraries will break (and this will break a lot of them). So I'm undoing this change by annotating this parameter as Nullable. Changelog: [Android] [Changed] - Undo a breaking change on ReactViewGroup constructor Reviewed By: tdn120 Differential Revision: D65483379
cortinico
force-pushed
the
export-D65483379
branch
from
b14247e to
64eb043
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65483379 |
Contributor
|
This pull request has been merged in bbe714e. |
Collaborator
|
This pull request was successfully merged by @cortinico in bbe714e When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
cipolleschi found out that we broke the
ReactViewGroupconstructor when making this class Nullsafe.Specifically now users would need to pass a
Contextand not aContext?as libraries will break (and this will break a lot of them).So I'm undoing this change by annotating this parameter as Nullable.
Changelog:
[Android] [Changed] - Undo a breaking change on ReactViewGroup constructor
Differential Revision: D65483379