Fix final few problematic React.ElementRef in react-native#47473
Closed
SamChou19815 wants to merge 1 commit into
Closed
Fix final few problematic React.ElementRef in react-native#47473SamChou19815 wants to merge 1 commit into
React.ElementRef in react-native#47473SamChou19815 wants to merge 1 commit into
Conversation
Summary: For example, ``` declare function C<T>(ref: React.RefSetter<Set<T>>): React.Node; type T = React.ElementRef<typeof C> ``` Previously Flow will evaluate `T` to `Set<mixed>`, by automatically replacing generic types with their upper bounds. But in the future it might be replaced with `empty`. This diff cleans up instances like this in react-native codebase. Changelog: [Internal] Differential Revision: D65562571
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65562571 |
Contributor
|
This pull request has been merged in 0ca2ba0. |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 0ca2ba0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For example,
Previously Flow will evaluate
TtoSet<mixed>, by automatically replacing generic types with their upper bounds. But in the future it might be replaced withempty.This diff cleans up instances like this in react-native codebase.
Changelog: [Internal]
Differential Revision: D65562571