Enable RSNRS only on JS thread#47637
Closed
lenaic wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64500893 |
lenaic
force-pushed
the
export-D64500893
branch
from
690f2dd to
dd62094
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64500893 |
lenaic
force-pushed
the
export-D64500893
branch
from
dd62094 to
7df8e27
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64500893 |
lenaic
force-pushed
the
export-D64500893
branch
from
7df8e27 to
88b6450
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64500893 |
Summary: Changelog: [Internal] RSNRS does not support off JS thread layout due to current fiber tree corruption when syncing happens on more than one shadow tree at the same time. This diff guarantees that RSNRS will only be enabled on the JS thread, avoiding any state corruption. Differential Revision: D64500893
lenaic
force-pushed
the
export-D64500893
branch
from
88b6450 to
2f37928
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64500893 |
Contributor
|
This pull request has been merged in 2944752. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in 2944752 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
RSNRS does not support off JS thread layout due to current fiber tree corruption when syncing happens on more than one shadow tree at the same time. This diff guarantees that RSNRS will only be enabled on the JS thread, avoiding any state corruption.
Differential Revision: D64500893