Mark ReactPackage#getModule as stable#47676
Closed
javache wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66127068 |
Summary: No longer referenced and removed from public exports in D49752133 Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D66127071
Summary: `getModule` is used by all modern ReactPackage base-classes to allow lazy loading of specific module and should be considered stable at this point. Changelog: [Android][Added] Marked ReactPackage#getModule as stable. Reviewed By: mdvacca Differential Revision: D66127068
javache
force-pushed
the
export-D66127068
branch
from
766a83d to
a4d9428
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66127068 |
Contributor
|
This pull request has been merged in 8fba7eb. |
Collaborator
|
This pull request was successfully merged by @javache in 8fba7eb When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
getModuleis used by all modern ReactPackage base-classes to allow lazy loading of specific module and should be considered stable at this point.Changelog: [Android][Added] Marked ReactPackage#getModule as stable.
Differential Revision: D66127068