Remove deprecated ReactModuleInfo constructor#47681
Closed
javache wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66127070 |
Summary: This was deprecated in D50128456 so should be safe to remove now. Changelog: [Android][Removed] Removed TurboReactPackage, which was replaced by BaseReactPackage Reviewed By: mdvacca Differential Revision: D66127067
Summary: These were deprecated back in D49262824, so should be safe to remove now. Changelog: [Android][Removed] Removed hasConstants constructor from ReactModuleInfo Reviewed By: mdvacca Differential Revision: D66127070
javache
force-pushed
the
export-D66127070
branch
from
8936f1b to
a10a077
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66127070 |
Contributor
|
This pull request has been merged in aec7a66. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
These were deprecated back in D49262824, so should be safe to remove now.
Changelog: [Android][Removed] Removed hasConstants constructor from ReactModuleInfo
Differential Revision: D66127070