Remove trivial private api calls in YogaLayoutableShadowNode.cpp#47735
Closed
joevilches wants to merge 1 commit into
Closed
Remove trivial private api calls in YogaLayoutableShadowNode.cpp#47735joevilches wants to merge 1 commit into
joevilches wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66131948 |
joevilches
force-pushed
the
export-D66131948
branch
from
35e52fa to
31d9510
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66131948 |
…ebook#47735) Summary: We are trying to remove or minimize private header usage in YogaLayoutableShadowNode.cpp and YogaLayoutableShadowNode.h. There are a few "trivial" ones, meaning some private call maps 1:1 to an existing public API, so I just opt to use that instead Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66131948
joevilches
force-pushed
the
export-D66131948
branch
from
31d9510 to
a291397
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66131948 |
Contributor
|
This pull request has been merged in 6d8fd49. |
Collaborator
|
This pull request was successfully merged by @joevilches in 6d8fd49 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We are trying to remove or minimize private header usage in YogaLayoutableShadowNode.cpp and YogaLayoutableShadowNode.h. There are a few "trivial" ones, meaning some private call maps 1:1 to an existing public API, so I just opt to use that instead
Differential Revision: D66131948