Remove native -> js call noop-ing after early js error#47915
Closed
RSNara wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66394278 |
Summary: ## Purpose of this noop-ing If an fatal js error happens during js runtime init, the js thread continues executing and raises **yet another** fatal error. This noop-ing was an **attempt** to prevent that second inactionable fatal from happening: That fatal is usually inactionable. ## Problems with this noop-ing I don't think this is the right approach: There could be legitimate reasons to continue executing native -> js calls post first js fatal. I don't think it does *much*: it doesn't noop native -> js calls executed on the runtime scheduler, which should be most of them. ## Changes Instead of trying to prevent that fatal, just let it happen. Then, don't report the second fatal: D66193194 and D66392706. ## Safetly The production impact is negligible: This codepath is executed only after early js errors. There shouldn't be any in production right now. We've spent a lot of time making our javascript error handling pipeline's coverage compresive. So, after an early js fatal error happens, subsequent js fatals should get handled properly. Changelog: [Internal] Differential Revision: D66394278
RSNara
force-pushed
the
export-D66394278
branch
from
a6eb432 to
9a59c49
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66394278 |
Contributor
|
This pull request has been merged in 69ecaef. |
Collaborator
|
This pull request was successfully merged by @RSNara in 69ecaef When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Purpose of this noop-ing
If an fatal js error happens during js runtime init, the js thread continues executing and raises yet another fatal error. That fatal is usually inactionable. This noop-ing was an attempt to prevent that second inactionable fatal from happening.
Problems with this noop-ing
I don't think this is the right approach: There could be legitimate reasons to continue executing native -> js calls post js fatal.
I don't think it does much: it doesn't noop native -> js calls executed on the runtime scheduler, which should be most of them. Note: Runtime scheduler executes several tasks on the same tick of runtime executor. So, if a runtime scheduler tasks raises a fatal erorr, subsequent runtime scheduler tasks will continue executing.
Changes
Instead of trying to prevent that fatal, just let it happen. We recently shipped changes that made sure the error reporting pipeline didn't report the second fatal: D66193194 and D66392706.
Safetly
This codepath is only executed after early js errors. There shouldn't be any in production right now. So the production impact is negligible.
We've spent a lot of time beefing up our early js pipeline. And it covers fatal js errors pretty comprehensively. So, whenever an early js error happens, subsequent js fatals should get reported and handled properly.
Changelog: [Internal]
Differential Revision: D66394278