Skip to content

fix:setColorScheme exception when activity recreate#47955

Closed
high726 wants to merge 1 commit into
facebook:mainfrom
high726:features/fix_set_theme
Closed

fix:setColorScheme exception when activity recreate#47955
high726 wants to merge 1 commit into
facebook:mainfrom
high726:features/fix_set_theme

Conversation

@high726
Copy link
Copy Markdown

@high726 high726 commented Nov 26, 2024

Summary:

solve the exception on android when Appearance.setColorScheme and activity recreate()
issue:47954

Changelog:

[Android][Fixed] setColorScheme should be called on the UI thread

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @Maplely!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Nov 26, 2024

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 5c8d195

@high726 high726 force-pushed the features/fix_set_theme branch from cb3a487 to 2a0a941 Compare November 26, 2024 13:13
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 26, 2024
@high726 high726 force-pushed the features/fix_set_theme branch 2 times, most recently from f104e5c to f2b86df Compare November 26, 2024 13:23
@high726 high726 force-pushed the features/fix_set_theme branch from f2b86df to 5c8d195 Compare November 26, 2024 13:27
Copy link
Copy Markdown

@anandfresh anandfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maplely It looks good to me, but there are a couple of build issues to fix.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 28, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache merged this pull request in 2aa7997.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by lihaitao in 2aa7997

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants