Demonstrate bug in differentiator where reparented nodes reference non-existent nodes#48002
Closed
javache wants to merge 1 commit into
Closed
Demonstrate bug in differentiator where reparented nodes reference non-existent nodes#48002javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
…n-existent nodes Summary: Demonstrates the issue identified in facebook#47960 and a crash we've been seeing internally around `getViewState` referencing a view that does not exist. When reparenting unflattened nodes, Differentiator may emit an `update` with a `parentShadowView` that does not exist on the native side yet, thereby crashing Android. Landing the test-case first (with some test cleanup), so the diff for the actual fix is clearer. Changelog: [Internal] Differential Revision: D66557919
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66557919 |
Contributor
|
This pull request has been merged in bc9e4db. |
Collaborator
|
This pull request was successfully merged by @javache in bc9e4db When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Demonstrates the issue identified in #47960 and a crash we've been seeing internally around
getViewStatereferencing a view that does not exist.When reparenting unflattened nodes, Differentiator may emit an
updatewith aparentShadowViewthat does not exist on the native side yet, thereby crashing Android.Landing the test-case first (with some test cleanup), so the diff for the actual fix is clearer.
Changelog: [Internal]
Differential Revision: D66557919