Extract logic to debug command errors to shared function#48019
Closed
rubennorte wants to merge 3 commits into
Closed
Extract logic to debug command errors to shared function#48019rubennorte wants to merge 3 commits into
rubennorte wants to merge 3 commits into
Conversation
Summary: Changelog: [internal] Just a small refactor in preparation for a following change that will add more usages for these utilities. It also cleans up the runner file which is good too. Differential Revision: D66595405
…unning time (facebook#48015) Summary: Changelog: [internal] Right now, when we run individual Fantom tests, we compile Hermes and the RN Tester CLI as part of the test, which causes the first test to run to be very slow and the remaining tests in the same run to be very fast. This is misleading because it makes it look like the test itself is slow, when it's actually paying a price for everyone. Fortunately, Jest has an option to do a global setup before any tests in the project run (and it doesn't run if none of the tests in the project run, in multi-project setups), so we can use it to do the necessary warmup so it doesn't end up being attributed to individual tests. Differential Revision: D66595406
Differential Revision: D66596730
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66596730 |
Collaborator
Contributor
|
This pull request has been merged in 762389f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D66596730