Update FuseboxTracer to closer align with Chrome trace events#48020
Closed
huntie wants to merge 1 commit into
Closed
Update FuseboxTracer to closer align with Chrome trace events#48020huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
Summary: Progress towards Performance panel display parity for User Timing events in Chrome DevTools. - Support nullable `track` name in `ReactPerfLogger`, passing track name directly to `FuseboxTracer`. - Update `FuseboxTracer` to register "Main" process and send V8-aligned `blink.user_timing`-categorised tracing events. The previous track naming strategy continues to be used under Perfetto. Changelog: [Internal] **Better, but not perfect yet** For now, this is probably the upper limit of how aligned we can be with Chrome on web, since our forked DevTools frontend is 6mo+ behind `main`. Notably, it does not include equivalent custom track handling today: ChromeDevTools/devtools-frontend@4b4435f {F1969750671} > Importing an exact trace from Chrome into RNDT is unable to sub-group the "Timings" track. Differential Revision: D66579308
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66579308 |
Contributor
|
This pull request has been merged in 11c214d. |
Collaborator
|
This pull request was successfully merged by @huntie in 11c214d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Progress towards Performance panel display parity for User Timing events in Chrome DevTools.
trackname inReactPerfLogger, passing track name directly toFuseboxTracer.FuseboxTracerto register "Main" process and send V8-alignedblink.user_timing-categorised tracing events.The previous track naming strategy continues to be used under Perfetto.
Changelog: [Internal]
Better, but not perfect yet
For now, this is probably the upper limit of how aligned we can be with Chrome on web, since our forked DevTools frontend is 6mo+ behind
main. Notably, it does not include equivalent custom track handling today: ChromeDevTools/devtools-frontend@4b4435f{F1969750671}
Differential Revision: D66579308