Migrate ReactFabricPublicInstance tests to Fantom#48025
Closed
rubennorte wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66599070 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66599070 |
rubennorte
force-pushed
the
export-D66599070
branch
from
e39cfc5 to
626690f
Compare
Differential Revision: D66599071
Summary: Pull Request resolved: facebook#48025 Changelog: [internal] This migrates the existing tests we have for the current public API for host component refs to Fantom. After this, the only remaining test to migrate before we can clean up the legacy mocks for Fabric, etc. is the one for IntersectionObserer. Differential Revision: D66599070
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66599070 |
rubennorte
force-pushed
the
export-D66599070
branch
from
626690f to
8d0a13a
Compare
Contributor
|
This pull request has been merged in 60a4d22. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This migrates the existing tests we have for the current public API for host component refs to Fantom.
After this, the only remaining test to migrate before we can clean up the legacy mocks for Fabric, etc. is the one for IntersectionObserer.
Differential Revision: D66599070