Remove some web debugging remnants#48054
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66553934 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66553934 |
NickGerleman
force-pushed
the
export-D66553934
branch
from
414abc0 to
7119161
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66553934 |
NickGerleman
force-pushed
the
export-D66553934
branch
from
7119161 to
d65e751
Compare
Summary: Pull Request resolved: facebook#48054 Web debugging should be fully removed as of recent, so lets remove some of the gunk that was powering it, and checks for that environment. I did some string searches for the following: * isAsyncDebugging * debugRemotely * isDebuggingRemotely * isRemoteDebuggingAvailable * WebSocketExecutor * JavaJSExecutor * ProxyJavaScriptExecutor * RELOAD_APP_EXTRA_JS_PROXY * getJSBundleURLForRemoteDebugging * onReloadWithJSDebugger * setRemoteJSDebugEnabled * WebsocketJavaScriptExecutor * createRemoteDebuggerBundleLoader 1. `expo-modules-core` exposes its own `isAsyncDebugging` by checking for `nativeCallSyncHook`, but does not depend on `DebugEnvironment`. 2. `expo-dev-menu` does read `isDebuggingRemotely` from `DevSettings`. 3. Realm does a check in Native using `objc_lookUpClass("RCTWebSocketExecutor")` but will gracefully handle `nil` if it does not exist 4. Some more usages (e.g. `onReloadWithJSDebugger`) in vendored packages of `expo-dev-launcher` for RN 0.74 I created an issue for Expo mentioning both here: expo/expo#33371 Changelog: [General][Breaking] - Remove some web debugging remnants Reviewed By: huntie Differential Revision: D66553934
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66553934 |
NickGerleman
force-pushed
the
export-D66553934
branch
from
d65e751 to
bc4817f
Compare
Contributor
|
This pull request has been merged in 9aae84a. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 9aae84a When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Web debugging should be fully removed as of recent, so lets remove some of the gunk that was powering it, and checks for that environment.
Expo will need to potentially mirror this update. Created an issue here: expo/expo#33371
Changelog:
[General][Breaking] - Remove some web debugging remnants
Differential Revision: D66553934