Skip to content

Reduce visibility of ComponentNameResolver to internal #48056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 2 commits into from
Closed

Reduce visibility of ComponentNameResolver to internal #48056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f41787
Convert xplat/js/react-native-github/packages/react-native/ReactAndro…
mdvacca Dec 3, 2024
b1f82f3
Reduce visibility of ComponentNameResolver to internal
mdvacca Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4095,10 +4095,6 @@ public abstract class com/facebook/react/uimanager/BaseViewManagerDelegate : com
public fun setProperty (Landroid/view/View;Ljava/lang/String;Ljava/lang/Object;)V
}

public abstract interface class com/facebook/react/uimanager/ComponentNameResolver {
public abstract fun getComponentNames ()[Ljava/lang/String;
}

public final class com/facebook/react/uimanager/DisplayMetricsHolder {
public static final field INSTANCE Lcom/facebook/react/uimanager/DisplayMetricsHolder;
public static final fun getDisplayMetricsWritableMap (D)Lcom/facebook/react/bridge/WritableMap;
Expand Down
9 changes: 4 additions & 5 deletions ...eact/uimanager/ComponentNameResolver.java → .../react/uimanager/ComponentNameResolver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@
* LICENSE file in the root directory of this source tree.
*/

package com.facebook.react.uimanager;
package com.facebook.react.uimanager

import com.facebook.proguard.annotations.DoNotStripAny;
import com.facebook.proguard.annotations.DoNotStripAny

@DoNotStripAny
public interface ComponentNameResolver {

internal interface ComponentNameResolver {
/* returns a list of all the component names that are registered in React Native. */
String[] getComponentNames();
public val componentNames: Array<String>?
}