Allow async functions in ReactNativeTester and add tests#48063
Closed
rubennorte wants to merge 1 commit into
Closed
Allow async functions in ReactNativeTester and add tests#48063rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66698547 |
rubennorte
force-pushed
the
export-D66698547
branch
from
b037250 to
d9cba8e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66698547 |
rubennorte
force-pushed
the
export-D66698547
branch
from
d9cba8e to
7ac1c46
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66698547 |
rubennorte
force-pushed
the
export-D66698547
branch
from
7ac1c46 to
8276d23
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66698547 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 5, 2024
…acebook#48063) Summary: Changelog: [internal] This allows async functions to be passed to `runTask` (just a type change really) and adds tests for ReactNativeTester. Error handling isn't currently set up correctly, so those tests are disabled for now. Reviewed By: sammy-SC Differential Revision: D66698547
Contributor
|
This pull request has been merged in 118c18f. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 118c18f When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This allows async functions to be passed to
runTask(just a type change really) and adds tests for ReactNativeTester. Error handling isn't currently set up correctly, so those tests are disabled for now.Differential Revision: D66698547