test(network): [android] ResponseUtil unit tests#48075
Closed
mateoguzmana wants to merge 2 commits intofacebook:mainfrom
Closed
test(network): [android] ResponseUtil unit tests#48075mateoguzmana wants to merge 2 commits intofacebook:mainfrom
ResponseUtil unit tests#48075mateoguzmana wants to merge 2 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@lunaleaps merged this pull request in 50d0157. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 50d0157 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…8781) Summary: As in the title, follow up from #48075 which added unit tests for this class. ## Changelog: [INTERNAL] - Convert com.facebook.react.modules.network.ResponseUtil to Kotlin Pull Request resolved: #48781 Test Plan: ```bash ./gradlew :packages:react-native:ReactAndroid:test -Dtest.single=com.facebook.react.modules.network ``` Reviewed By: javache Differential Revision: D68393938 Pulled By: Abbondanzo fbshipit-source-id: ed214b29ad9248c2da2e2653e75447b0a7e05a26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently the class
ResponseUtilis still in Java, I'm adding some unit tests so it is safer to migrate it to Kotlin.Changelog:
[INTERNAL] -
ResponseUtilunit testsTest Plan: