Convert com.facebook.react.modules.network.ReactCookieJarContainer to Kotlin#48089
Closed
javache wants to merge 2 commits into
Closed
Convert com.facebook.react.modules.network.ReactCookieJarContainer to Kotlin#48089javache wants to merge 2 commits into
javache wants to merge 2 commits into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66724567 |
… Kotlin Summary: Planning to make some changes here for perf, but converting to Kotlin first Changelog: [Internal] Differential Revision: D66724321
f9566d5 to
aa36133
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66724567 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66724567 |
aa36133 to
ce84064
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66724567 |
ce84064 to
8f227b3
Compare
… Kotlin (facebook#48089) Summary: Pull Request resolved: facebook#48089 Planning to make some changes here for perf, but converting to Kotlin first Changelog: [Android][Removed] Made ReactCookieJarContainer internal. Reviewed By: tdn120 Differential Revision: D66724567
8f227b3 to
8c0d6bf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66724567 |
Contributor
|
This pull request has been merged in 18ebea5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Planning to make some changes here for perf, but converting to Kotlin first
Changelog: [Internal]
Differential Revision: D66724567