Fix React-graphics podspec source_files#48216
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67095677 |
Summary: The `React-graphics` podspec is manually excluding some paths from the source_files but this approach is error prone. For esample changes that added new paths that must be excluded can create failures. This change the podspec file to explicitly add only the files that iOS requires. ## Changelog: [iOS][Changed] - Explicitly define the source files for React-graphics ## Facebook: This change is necessary because we added the macos platform that was not included before and now we can't build RNTester from fbsource using the internal pipeline. Reviewed By: hoxyq Differential Revision: D67095677
cipolleschi
force-pushed
the
export-D67095677
branch
from
f56666a to
4460730
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67095677 |
Contributor
|
This pull request has been merged in 3ff9212. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 3ff9212 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
React-graphicspodspec is manually excluding some paths from the source_files but this approach is error prone. For esample changes that added new paths that must be excluded can create failures.This change the podspec file to explicitly add only the files that iOS requires.
Changelog:
[iOS][Changed] - Explicitly define the source files for React-graphics
Differential Revision: D67095677