Skip to content

Exclude packages/react-native/ReactAndroid/build from lint checks#48217

Closed
mateoguzmana wants to merge 1 commit into
facebook:mainfrom
mateoguzmana:chore/excluding-build-folder-from-local-linting
Closed

Exclude packages/react-native/ReactAndroid/build from lint checks#48217
mateoguzmana wants to merge 1 commit into
facebook:mainfrom
mateoguzmana:chore/excluding-build-folder-from-local-linting

Conversation

@mateoguzmana
Copy link
Copy Markdown
Collaborator

@mateoguzmana mateoguzmana commented Dec 11, 2024

Summary:

When running the linter locally, noise is generated from the packages/react-native/ReactAndroid/build folder. This folder does not need to be checked, as it is already excluded in the .gitignore.

Changelog:

[INTERNAL] - Exclude packages/react-native/ReactAndroid/build from lint checks

Test Plan:

yarn lint

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2024
@mateoguzmana mateoguzmana changed the title Exclude packages/react-native/ReactAndroid/build from lint checks. Exclude packages/react-native/ReactAndroid/build from lint checks Dec 11, 2024
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 11, 2024
Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. 🙏

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 12, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in dffa57f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants