Make feature flags module and overrides read-only#48229
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67109719 |
rubennorte
force-pushed
the
export-D67109719
branch
from
d82b3b9 to
d2aafb2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67109719 |
…#48229) Summary: Changelog: [internal] The type definitions for these objects (the exported value by the `ReactNativeFeatureFlags` module, and the input value for `ReactNativeFeatureFlags.override()` method) were writable objects, which is incorrect and causes other problems down the line. This just makes them read-only. Reviewed By: yungsters Differential Revision: D67109719
rubennorte
force-pushed
the
export-D67109719
branch
from
d2aafb2 to
be068ff
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67109719 |
Contributor
|
This pull request has been merged in 11c49d6. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 11c49d6 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
The type definitions for these objects (the exported value by the
ReactNativeFeatureFlagsmodule, and the input value forReactNativeFeatureFlags.override()method) were writable objects, which is incorrect and causes other problems down the line.This just makes them read-only.
Reviewed By: yungsters
Differential Revision: D67109719