Skip to content

Add missing glog dep to React-idlecallbacksnativemodule.podspec#48241

Closed
NickGerleman wants to merge 1 commit into
mainfrom
NickGerleman-missing-glog-dep
Closed

Add missing glog dep to React-idlecallbacksnativemodule.podspec#48241
NickGerleman wants to merge 1 commit into
mainfrom
NickGerleman-missing-glog-dep

Conversation

@NickGerleman
Copy link
Copy Markdown
Contributor

react_native_assert on iOS uses glog under the hood, and #47911 added usage to a new podspec, which means new entire binary under some build modes. Need to add missing dependency I think?

Changelog: [Internal]

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 12, 2024
@react-native-bot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 28beded

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @NickGerleman in f4a17fb

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants