Remove GuardedAsyncTask wrapper for call.cancel()#48251
Closed
tdn120 wants to merge 1 commit intofacebook:mainfrom
Closed
Remove GuardedAsyncTask wrapper for call.cancel()#48251tdn120 wants to merge 1 commit intofacebook:mainfrom
tdn120 wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67157018 |
tdn120
force-pushed
the
export-D67157018
branch
from
2948dea to
0f08457
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67157018 |
tdn120
force-pushed
the
export-D67157018
branch
from
0f08457 to
cb00e72
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67157018 |
tdn120
force-pushed
the
export-D67157018
branch
from
cb00e72 to
9d76233
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67157018 |
tdn120
force-pushed
the
export-D67157018
branch
from
9d76233 to
568bd9c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67157018 |
Summary: The original comment mentioning square/okhttp#869 predates the [upgrade to okhttp3](facebook@6bbaff2), which resolved the issue via square/okhttp#1592. Cancel calls should now be async and don't need to be guarded. Removing this also fixes a discrepancy in NetworkingModule unit test verification. Changelog: [Internal] Reviewed By: javache Differential Revision: D67157018
tdn120
force-pushed
the
export-D67157018
branch
from
568bd9c to
014326c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67157018 |
Contributor
|
This pull request has been merged in 783cc57. |
Collaborator
|
This pull request was successfully merged by Thomas Nardone in 783cc57 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The original comment mentioning square/okhttp#869 predates the upgrade to okhttp3, which resolved the issue via square/okhttp#1592.
Cancel calls should now be async and don't need to be guarded. Removing this also fixes a discrepancy in NetworkingModule unit test verification.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D67157018