[Android] ScrollView: handling testID correctly for horizontal scroll view

[mateoguzmana]

Summary:

Fixes #46180

This PR fixes the testID not being set as a resource-id in the HorizontalScrollView.

Currently the resource-id is being set correctly when we use a vertical scroll view (this is done here for reference) but we still miss setting this when we use a horizontal one as the managers for both components are different.

Changelog:

[ANDROID][FIXED] - Handling testID correctly for horizontal scroll view

Test Plan:

Render a simple ScrollView component with horizontal set as true and pass a testID property as shown:

function Playground() {
  return (
    <ScrollView testID="customScrollViewTestId" horizontal>
      <View
        style={{
          marginVertical: 400,
          backgroundColor: 'white',
          padding: 14,
          margin: 50,
          width: 200,
          height: 200,
        }}
      />
    </ScrollView>
  );
}

Open Maestro Studio and search for customScrollViewTestId in the search bar.

Before the fix: The `testID` is not found. (See screenshot)

See the same in Appium. (See screenshot)

---

Apply this fix, and search again in Maestro Studio.

After the fix: The `testID` is now recognised and can be found in the search bar. (See screenshot)

See the same in Appium. (See screenshot)

[javache]

ReactScrollViewManager derives from BaseViewManager which already overrides setTestId. Could you please debug why that method isn't getting invoked?

[mateoguzmana]

ReactScrollViewManager derives from BaseViewManager which already overrides setTestId. Could you please debug why that method isn't getting invoked?

@javache thanks to your observation, I went back and checked the full flow and actually the methods were called correctly. When doing my fix I did some clean up in the repro example and actually made me think it got fixed (my mistake during testing 😄)

With the above said, I narrowed down the issue and discovered it only happens when we use a horizontal scroll view. For the vertical one it was working already correctly.

I've updated the PR info as well to reflect this, used also Appium to double check it's not a problem of a single e2e tool.

[javache]

Awesome, thanks for digging in!

[facebook-github-bot]

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@javache merged this pull request in 81c74cd.

[react-native-bot]

This pull request was successfully merged by @mateoguzmana in 81c74cd

^{When will my fix make it into a release? | How to file a pick request?}