Map SystraceSection to Perfetto instrumentation if the latter is enabled#48379
Closed
rshest wants to merge 1 commit intofacebook:mainfrom
Closed
Map SystraceSection to Perfetto instrumentation if the latter is enabled#48379rshest wants to merge 1 commit intofacebook:mainfrom
rshest wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67619443 |
rshest
force-pushed
the
export-D67619443
branch
from
50561b5 to
087ce66
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67619443 |
rshest
force-pushed
the
export-D67619443
branch
from
087ce66 to
2cb98ef
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67619443 |
rshest
force-pushed
the
export-D67619443
branch
from
2cb98ef to
02cc6cc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67619443 |
…led (facebook#48379) Summary: ## Changelog: [Internal] - We have a good portion of RN core code already instrumented with `SystraceSection` blocks, and those do the timing via fbsystrace, which may or may not be enabled in the system and generally is obsolete. This maps the blocks to the corresponding Perfetto instrumentation, in case the latter is enabled, which will allow to get this information in Perfetto sessions without need to have fbsystrace present. Reviewed By: javache Differential Revision: D67619443
rshest
force-pushed
the
export-D67619443
branch
from
02cc6cc to
879da82
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67619443 |
Contributor
|
This pull request has been merged in 17a644a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
We have a good portion of RN core code already instrumented with
SystraceSectionblocks, and those do the timing via fbsystrace, which may or may not be enabled in the system and generally is obsolete.This maps the blocks to the corresponding Perfetto instrumentation, in case the latter is enabled, which will allow to get this information in Perfetto sessions without need to have fbsystrace present.
Differential Revision: D67619443