Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67670976 |
cipolleschi
force-pushed
the
export-D67670976
branch
from
6234e4b to
daecad2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67670976 |
cipolleschi
force-pushed
the
export-D67670976
branch
from
daecad2 to
a945c66
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67670976 |
Summary:
A couple of days ago, the iOS CI started failing for the E2E tests on main.
This is because We were not using the hermes artifacts we were preconfiguring.
In fact, this is the log of the `test_e2e_ios_rntester`, which is not using the prebuilt.
{F1974129000}
For comparison, this is the `test_ios_rntester`, which is using the prebuilt
{F1974129001}
While investigating why this was happening, I realized that we were not testing the old architecture anymore, because we forget to update the script after the release of the New Architecture.
This change should fix both.
## Changelog:
[Internal] - Fix E2E tests for iOS and test the Old Arch
Reviewed By: robhogan
Differential Revision: D67670976
cipolleschi
force-pushed
the
export-D67670976
branch
from
a945c66 to
740b85a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67670976 |
Contributor
|
This pull request has been merged in 9ceabd3. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 9ceabd3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A couple of days ago, the iOS CI started failing for the E2E tests on main.
This is because We were not using the hermes artifacts we were preconfiguring.
In fact, this is the log of the
test_e2e_ios_rntester, which is not using the prebuilt.{F1974129000}
For comparison, this is the
test_ios_rntester, which is using the prebuilt{F1974129001}
While investigating why this was happening, I realized that we were not testing the old architecture anymore, because we forget to update the script after the release of the New Architecture.
This change should fix both.
Changelog:
[Internal] - Fix E2E tests for iOS and test the Old Arch
Differential Revision: D67670976