Fix case when dashed/dotted borders do not work with overflow: hidden#48414
Fix case when dashed/dotted borders do not work with overflow: hidden#48414joevilches wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67720492 |
joevilches
force-pushed
the
export-D67720492
branch
from
3d4d2e3 to
fd5d70e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67720492 |
…facebook#48414) Summary: Was looking into facebook#48078 which was brought to my attention due to my recent refactorings of iOS Views, especially around how overflow: hidden works. This bug was not brought on by my changes but seems to be a lingering Fabric bug (iirc this bool was not changed when I refactored things) Anyway, dotted/dashed borders did not work with overflow: hidden. The reason why is we use core animation borders in this case which is incorrect as CA cannot do these types of borders. So I added a check to make sure that the borders are solid as well if we want to use CA to draw them. Changelog: [iOS] [Fixed] - Dashed & dotted borders now work with overflow: hidden Reviewed By: mdvacca Differential Revision: D67720492
joevilches
force-pushed
the
export-D67720492
branch
from
fd5d70e to
c92b3bb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67720492 |
|
This pull request has been merged in 1b88c5b. |
|
This pull request was successfully merged by @joevilches in 1b88c5b When will my fix make it into a release? | How to file a pick request? |
|
@joevilches Is this fix going to work if we are using the old architecture? In RN 0.76.6 the dashed border is working if we don't have a border radius. As soon as we add some value, the dashed border becomes solid. |
|
@mduchev this fix will only work for the new arch. The old arch fix might be a small patch too but I only looked at the new arch code for this one |
4 participants
Summary:
Was looking into #48078 which was brought to my attention due to my recent refactorings of iOS Views, especially around how overflow: hidden works. This bug was not brought on by my changes but seems to be a lingering Fabric bug (iirc this bool was not changed when I refactored things)
Anyway, dotted/dashed borders did not work with overflow: hidden. The reason why is we use core animation borders in this case which is incorrect as CA cannot do these types of borders. So I added a check to make sure that the borders are solid as well if we want to use CA to draw them.
Differential Revision: D67720492