Extract ensureInstance utility from tests#48434
Closed
rubennorte wants to merge 4 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67520443 |
…book#48433) Summary: Changelog: [internal] Allows customizing the root dimensions. Reviewed By: christophpurrer Differential Revision: D67693031
Summary: Changelog: [internal] Just a small refactor to slightly improve readability (and potentially performance). Reviewed By: christophpurrer Differential Revision: D67520444
Summary: Changelog: [internal] We were starting to repeat this logic too much in tests, so extracting so we can reuse it. Reviewed By: rshest Differential Revision: D67520443
rubennorte
force-pushed
the
export-D67520443
branch
from
a46c70b to
320f1be
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67520443 |
Contributor
|
This pull request has been merged in a1b13f6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
We were starting to repeat this logic too much in tests, so extracting so we can reuse it.
Differential Revision: D67520443