Build Release version for RNTester to speed-up E2E#48443
Closed
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Closed
Build Release version for RNTester to speed-up E2E#48443cipolleschi wants to merge 1 commit intofacebook:mainfrom
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760372 |
cipolleschi
force-pushed
the
export-D67760372
branch
from
84c85e0 to
fd55cdb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760372 |
cipolleschi
force-pushed
the
export-D67760372
branch
from
fd55cdb to
c04a0a9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760372 |
cipolleschi
force-pushed
the
export-D67760372
branch
from
c04a0a9 to
2a7b4e5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760372 |
cipolleschi
force-pushed
the
export-D67760372
branch
from
2a7b4e5 to
53ad793
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760372 |
cipolleschi
force-pushed
the
export-D67760372
branch
from
53ad793 to
2acd22d
Compare
Summary: This change makes sure we build the Release variant of RNTester so we can store the generated app as an artifact and forward it to the E2E tests. ## Context While looking at the recent failures of the E2E tests, I realized that the Hermes, NewArch, Debug variant often fails to build, not to test, for some misconfiguration. I also realized that we are already building that varaint successfully once, so why not reuse it? To reuse prebuilds, we need a few steps: 1. make sure we build all the variants we need 2. store the .app file as an artifact 3. download the artifact and use it in the E2E tests ## Changelog: [Internal] - Build release variant for RNTester Differential Revision: D67760372
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760372 |
cipolleschi
force-pushed
the
export-D67760372
branch
from
2acd22d to
c257566
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760372 |
Contributor
|
This pull request has been merged in 2c338a7. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 2c338a7 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change makes sure we build the Release variant of RNTester so we can store the generated app as an artifact and forward it to the E2E tests.
Context
While looking at the recent failures of the E2E tests, I realized that the Hermes, NewArch, Debug variant often fails to build, not to test, for some misconfiguration.
I also realized that we are already building that varaint successfully once, so why not reuse it? To reuse prebuilds, we need a few steps:
Changelog:
[Internal] - Build release variant for RNTester
Differential Revision: D67760372