[RN][iOS][E2E] Fix code to record and upload videos#48444
Closed
cipolleschi wants to merge 2 commits intofacebook:mainfrom
Closed
[RN][iOS][E2E] Fix code to record and upload videos#48444cipolleschi wants to merge 2 commits intofacebook:mainfrom
cipolleschi wants to merge 2 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
cd6f9aa to
291333a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
291333a to
da2d885
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
da2d885 to
07ce525
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
07ce525 to
9c8846e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
9c8846e to
dee2aed
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
dee2aed to
a84be89
Compare
cipolleschi
force-pushed
the
export-D67760436
branch
from
a84be89 to
27a14a2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
27a14a2 to
bde1260
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
6ee6ee8 to
ce51747
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
ce51747 to
c9bbb1e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
c9bbb1e to
e1e4e63
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
e1e4e63 to
a3b642b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
a3b642b to
51e4373
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
force-pushed
the
export-D67760436
branch
from
51e4373 to
bb461fd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 3, 2025
Summary: While debugging why the Debug variant was failing, I realised that the code to store video artifacts and the code to record the videos were not working properly. This diff fixes that ## Context While looking at the recent failures of the E2E tests, I realized that the Hermes, NewArch, Debug variant often fails to build, not to test, for some misconfiguration. I also realized that we are already building that varaint successfully once, so why not reuse it? To reuse prebuilds, we need a few steps: 1. make sure we build all the variants we need 2. store the .app file as an artifact 3. download the artifact and use it in the E2E tests ## Changelog: [Internal] - Build release variant for RNTester Differential Revision: D67760436
cipolleschi
changed the title
Collaborator
Summary: This change stores the RNTester `.app` in an artifact so that E2E tests can reuse it. ## Context While looking at the recent failures of the E2E tests, I realized that the Hermes, NewArch, Debug variant often fails to build, not to test, for some misconfiguration. I also realized that we are already building that varaint successfully once, so why not reuse it? To reuse prebuilds, we need a few steps: 1. make sure we build all the variants we need 2. store the .app file as an artifact 3. download the artifact and use it in the E2E tests ## Changelog: [Internal] - Build release variant for RNTester Differential Revision: D67760380
Summary: While debugging why the Debug variant was failing, I realised that the code to store video artifacts and the code to record the videos were not working properly. This diff fixes that ## Context While looking at the recent failures of the E2E tests, I realized that the Hermes, NewArch, Debug variant often fails to build, not to test, for some misconfiguration. I also realized that we are already building that varaint successfully once, so why not reuse it? To reuse prebuilds, we need a few steps: 1. make sure we build all the variants we need 2. store the .app file as an artifact 3. download the artifact and use it in the E2E tests ## Changelog: [Internal] - Build release variant for RNTester Differential Revision: D67760436
cipolleschi
force-pushed
the
export-D67760436
branch
from
bb461fd to
43069d1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67760436 |
Contributor
|
This pull request has been merged in 9bf7aff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolved: #48444
While debugging why the Debug variant was failing, I realised that the code to store video artifacts and the code to record the videos were not working properly.
This diff fixes that
Context
While looking at the recent failures of the E2E tests, I realized that the Hermes, NewArch, Debug variant often fails to build, not to test, for some misconfiguration.
I also realized that we are already building that varaint successfully once, so why not reuse it? To reuse prebuilds, we need a few steps:
Changelog:
[Internal] - Build release variant for RNTester