Follow-ups to issues earlier in the stack#48455
Closed
blakef wants to merge 2 commits into
Closed
Conversation
Summary: This is the simplest possible way to track changes to our public CPP / Objective-C API. This is going to be really noisy, and there's a good chance it's not complete. The tooling is also incomplete, as it just runs the preprocessor (then does some funky work to undo noise generated by the preprocessor). If we want more control over this, we're going to have to jump into the guts of each of our build targets (and tooling) OR more clearer layout the repo to separate public and private header files to our users. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D67713408
Summary: This is a followup to earlier issues in the stack. Two fixes here: 1. Make the paths more consistent esp. from the config, so everything is working out of react-native-github. 2. Just declare `__cpluscplus`, as we don't seem to care about the value in our code. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D67716883
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67716883 |
Contributor
|
This pull request has been merged in 3a7aed6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a followup to earlier issues in the stack.
Two fixes here:
__cpluscplus, as we don't seem to care about the value in our code.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D67716883