Remove startEmptySurface from SurfaceManager#48479
Closed
christophpurrer wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67805569 |
Summary: [Changelog] [Internal] - Remove startEmptySurface from SurfaceManager Most of the logic deleted here does not seem to be needed as the core functionality is in: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp#L88-L96 And this code path can be reached both via - `startSurface` (by passing in an empty `moduleModule` OR - `startEmptySurface` Differential Revision: D67805569
christophpurrer
force-pushed
the
export-D67805569
branch
from
55a7d7b to
13a6709
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67805569 |
Contributor
|
This pull request has been merged in c4edfe7. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in c4edfe7 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Remove startEmptySurface from SurfaceManager
Most of the logic deleted here does not seem to be needed as the core functionality is in:
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp#L88-L96
And this code path can be reached both via
startSurface(by passing in an emptymoduleModuleORstartEmptySurfaceDifferential Revision: D67805569