Encapsulate Trace Event format#48648
Closed
hoxyq wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68104202 |
hoxyq
force-pushed
the
export-D68104202
branch
from
9435351 to
04829c9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68104202 |
hoxyq
force-pushed
the
export-D68104202
branch
from
04829c9 to
2274ddf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68104202 |
Summary: # Changelog: [Internal] This is the pre-requisite before adding a formatter for conversion from Hermes format-agnostic API for JavaScript samples to Trace Events. This struct will probably be used a lot around this module and big enough for a separate header. Reviewed By: huntie Differential Revision: D68104202
hoxyq
force-pushed
the
export-D68104202
branch
from
2274ddf to
32e8cda
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68104202 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 23, 2025
Summary: # Changelog: [Internal] This is the pre-requisite before adding a formatter for conversion from Hermes format-agnostic API for JavaScript samples to Trace Events. This struct will probably be used a lot around this module and big enough for a separate header. Reviewed By: huntie Differential Revision: D68104202
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 23, 2025
Summary: # Changelog: [Internal] This is the pre-requisite before adding a formatter for conversion from Hermes format-agnostic API for JavaScript samples to Trace Events. This struct will probably be used a lot around this module and big enough for a separate header. Reviewed By: huntie Differential Revision: D68104202
Contributor
|
This pull request has been merged in a995ecc. |
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: facebook#48648 # Changelog: [Internal] This is the pre-requisite before adding a formatter for conversion from Hermes format-agnostic API for JavaScript samples to Trace Events. This struct will probably be used a lot around this module and big enough for a separate header. Reviewed By: huntie Differential Revision: D68104202 fbshipit-source-id: 93f2816de5a87471c5f7761468ccc52a34a895d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This is the pre-requisite before adding a formatter for conversion from Hermes format-agnostic API for JavaScript samples to Trace Events.
This struct will probably be used a lot around this module and big enough for a separate header.
Reviewed By: huntie
Differential Revision: D68104202