Convert com.facebook.react.uimanager.ViewManagerPropertyUpdater to Kotlin#48658
Closed
javache wants to merge 1 commit into
Closed
Convert com.facebook.react.uimanager.ViewManagerPropertyUpdater to Kotlin#48658javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68102210 |
…tlin (facebook#48658) Summary: Pull Request resolved: facebook#48658 Migrate to Kotlin before I make further changes to this. Generics are really tricky due to our previous usage of raw generics on the Java side, but were worked around by some combination of unchecked cast and `Nothing` Changelog: [Internal] Reviewed By: mdvacca, rshest Differential Revision: D68102210
javache
force-pushed
the
export-D68102210
branch
from
c72731b to
fe8370b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68102210 |
Contributor
|
This pull request has been merged in 54ac150. |
Collaborator
|
This pull request was successfully merged by @javache in 54ac150 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrate to Kotlin before I make further changes to this. Generics are really tricky due to our previous usage of raw generics on the Java side, but were worked around by some combination of unchecked cast and
NothingChangelog: [Internal]
Differential Revision: D68102210