Provide default implementation of ViewManager#getDelegate#48664
Closed
javache wants to merge 2 commits into
Closed
Provide default implementation of ViewManager#getDelegate#48664javache wants to merge 2 commits into
javache wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68120420 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68120420 |
javache
force-pushed
the
export-D68120420
branch
from
c0ee8ce to
0aedadd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68120420 |
javache
force-pushed
the
export-D68120420
branch
from
0aedadd to
f265364
Compare
…tlin Differential Revision: D68102210
…8664) Summary: Pull Request resolved: facebook#48664 Simplify ViewManager base-class by making `ViewManager`'s delegate non-nullable and using a single path for updating properties. The ViewManagerDelegate API can map back to the original ViewManagerSetter API transparently, allowing us to remove the codepath from `ViewManagerPropertyUpdater`. Reviewed By: mdvacca, rshest Differential Revision: D68120420
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68120420 |
javache
force-pushed
the
export-D68120420
branch
from
f265364 to
d2a29af
Compare
Contributor
|
This pull request has been merged in a18bc58. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Simplify ViewManager base-class by making
ViewManager's delegate non-nullable and using a single path for updating properties.The ViewManagerDelegate API can map back to the original ViewManagerSetter API transparently, allowing us to remove the codepath from
ViewManagerPropertyUpdater.Reviewed By: rshest
Changelog: [Android][Removed] ViewManagerPropertyUpdater.updateProps is deprected, use the related ViewManager APIs instead
Differential Revision: D68120420