Skip to content

Migrate Libraries/Utilities/*.js to use export syntax.#48665

Closed
iwoplaza wants to merge 1 commit into
facebook:mainfrom
iwoplaza:export-D68152910
Closed

Migrate Libraries/Utilities/*.js to use export syntax.#48665
iwoplaza wants to merge 1 commit into
facebook:mainfrom
iwoplaza:export-D68152910

Conversation

@iwoplaza
Copy link
Copy Markdown
Contributor

Summary:

Motivation

Modernising the react-native codebase to allow for ingestion by modern Flow tooling

This diff

  • Updates files in Libraries/Utilities to use export syntax
    • export default for qualified objects, many export statements for collections (determined by how it's imported)
  • Appends .default to requires of the changed files.

Changelog:
[General][Breaking] - Files inside Libraries/Utilities use export syntax, which requires the addition of .default when imported with the CJS require syntax.

Differential Revision: D68152910

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 14, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@iwoplaza iwoplaza force-pushed the export-D68152910 branch 2 times, most recently from 7953b2a to 78f526e Compare January 14, 2025 19:34
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

)

Summary:
Pull Request resolved: facebook#48665

## Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling

## This diff
- Updates files in Libraries/Utilities to use `export` syntax
  - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported)
- Appends `.default` to requires of the changed files.
- Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files.
- Updates the public API snapshot (intented breaking change)

Changelog:
[General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax.

Reviewed By: huntie

Differential Revision: D68152910
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 24, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 52ffda7.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @iwoplaza in 52ffda7

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants