[Local] Disable useInsertionEffectsForAnimations
#48668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cipolleschi
changed the title
useInsertionEffectsForAnimations
Contributor
|
FYI - The corresponding commit to main has landed as c799aa0 - I'm going to cherry-pick that for consistency, rather than merge this. |
Contributor
|
Picked as 2013bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enabling
useInsertionEffectsForAnimationswas causing a regression where<Pressable>components becomes unresponsive. This happens when the<Pressable>'s position is controlled by a<ScrollView>offset and it is animated withnativeDriver.Changelog:
[General][Changed] - Disable useInsertionEffectsForAnimations
Test Plan:
Tested on RNTester, using the API > Animated > Pressability with Native Driver example