Skip to content

Migrate com.facebook.react.modules.network interfaces to Kotlin #48679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateoguzmana wants to merge 3 commits into from
Closed

Migrate com.facebook.react.modules.network interfaces to Kotlin #48679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c17304
Migrate ProgressListener to Kotlin
mateoguzmana Jan 14, 2025
5db1a64
Migrate CustomClientBuilder to Kotlin
mateoguzmana Jan 14, 2025
a9c7a98
Migrate NetworkInterceptorCreator to Kotlin
mateoguzmana Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .../modules/network/CustomClientBuilder.java → ...ct/modules/network/CustomClientBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
* LICENSE file in the root directory of this source tree.
*/

package com.facebook.react.modules.network;
package com.facebook.react.modules.network

import okhttp3.OkHttpClient;
import okhttp3.OkHttpClient

public interface CustomClientBuilder {
public void apply(OkHttpClient.Builder builder);
public fun interface CustomClientBuilder {
public fun apply(builder: OkHttpClient.Builder)
}
8 changes: 4 additions & 4 deletions ...es/network/NetworkInterceptorCreator.java → ...ules/network/NetworkInterceptorCreator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
* LICENSE file in the root directory of this source tree.
*/

package com.facebook.react.modules.network;
package com.facebook.react.modules.network

import okhttp3.Interceptor;
import okhttp3.Interceptor

/**
* Classes implementing this interface return a new {@link Interceptor} when the {@link #create}
* method is called.
*/
public interface NetworkInterceptorCreator {
Interceptor create();
public fun interface NetworkInterceptorCreator {
public fun create(): Interceptor
}
6 changes: 3 additions & 3 deletions ...act/modules/network/ProgressListener.java → ...react/modules/network/ProgressListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

package com.facebook.react.modules.network;
package com.facebook.react.modules.network

public interface ProgressListener {
void onProgress(long bytesWritten, long contentLength, boolean done);
public fun interface ProgressListener {
public fun onProgress(bytesWritten: Long, contentLength: Long, done: Boolean)
}