No need to invoke 'input keyevent 82' on test-e2e-local#48707
Closed
cortinico wants to merge 2 commits into
Closed
No need to invoke 'input keyevent 82' on test-e2e-local#48707cortinico wants to merge 2 commits into
cortinico wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| exec( | ||
| "adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed) ]]; do sleep 1; done; input keyevent 82'", | ||
| ); | ||
| exec("adb wait-for-device"); |
There was a problem hiding this comment.
quotes: Strings must use singlequote.
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 1b15f57. |
Collaborator
|
This pull request was successfully merged by @cortinico in 1b15f57 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The testing script is making unnecessary call to
input keyevent 82which causes the Android device toopen the menu. It's sufficient to just call
adb wait-for-deviceinstead.Changelog:
[Internal] [Changed] -
Test Plan:
Tested local with local device